Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 3, 2025


PR-Codex overview

This PR focuses on updating the layout of the project settings page in the layout.tsx file. It enhances the visual structure by modifying the header and the container for children components.

Detailed summary

  • Removed the existing <h1> and surrounding <div> for the header.
  • Added a new <div> with a bottom border and increased padding.
  • Wrapped the <h1> in a new container with a maximum width.
  • Adjusted the <h1> font size for responsiveness.
  • Updated the container for props.children to include padding adjustments.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2025 1:05pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 3, 2025 1:05pm
login ⬜️ Skipped (Inspect) Apr 3, 2025 1:05pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 3, 2025 1:05pm
wallet-ui ⬜️ Skipped (Inspect) Apr 3, 2025 1:05pm

@vercel vercel bot temporarily deployed to Preview – login April 3, 2025 12:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 3, 2025 12:50 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 3, 2025 12:50 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 3, 2025 12:50 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2025

⚠️ No Changeset found

Latest commit: 61583cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank MananTank marked this pull request as ready for review April 3, 2025 12:51
@MananTank MananTank requested review from a team as code owners April 3, 2025 12:51
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 3, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank added the hotfix This pull request should be prioritized in the merge queue. label Apr 3, 2025 — with Graphite App
Copy link
Member Author

MananTank commented Apr 3, 2025

Merge activity

@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.98%. Comparing base (cf02af0) to head (61583cf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6634   +/-   ##
=======================================
  Coverage   54.98%   54.98%           
=======================================
  Files         888      888           
  Lines       55753    55753           
  Branches     3816     3816           
=======================================
  Hits        30653    30653           
  Misses      25005    25005           
  Partials       95       95           
Flag Coverage Δ
packages 54.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.49 KB (0%) 950 ms (0%) 120 ms (+104.78% 🔺) 1.1 s
thirdweb (cjs) 129.89 KB (0%) 2.6 s (0%) 232 ms (+41.31% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 94 ms (+1349.44% 🔺) 206 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 26 ms (+1326.97% 🔺) 36 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 75 ms (+520.59% 🔺) 462 ms

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the layout of the `settings` page in the project dashboard. It enhances the styling and structure of the header and the content area.

### Detailed summary
- Replaced the existing `<h1>` element with a new structure wrapped in a `<div>` with a class of `border-b py-10`.
- Changed the font size of the `<h1>` from `text-3xl` to `text-2xl` for better responsiveness.
- Added a container with a maximum width of `7xl` around the header.
- Adjusted the padding of the content area to `pt-6 pb-20`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 04-03-dashboard_fix_project_settings_page_max-width branch from 9435953 to 61583cf Compare April 3, 2025 12:58
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 3, 2025 12:58 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 3, 2025 12:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 3, 2025 12:58 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 3, 2025 12:58 Inactive
@graphite-app graphite-app bot merged commit 61583cf into main Apr 3, 2025
32 checks passed
@graphite-app graphite-app bot removed the hotfix This pull request should be prioritized in the merge queue. label Apr 3, 2025
@graphite-app graphite-app bot deleted the 04-03-dashboard_fix_project_settings_page_max-width branch April 3, 2025 13:05
@vercel vercel bot temporarily deployed to Production – login April 3, 2025 13:05 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 3, 2025 13:05 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 3, 2025 13:05 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 3, 2025 13:05 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants